Fix MJ-RF conversion calculation#51
Merged
AlexIIL merged 1 commit intoBuildCraft:8.0.x-1.12.2from Oct 30, 2025
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RF->MJ->RF conversion in
receiveEnergy()was using the max receiveable MJmaxReceiveMJ, the amount before passing the power to theIMjReceiver, to calculate resultant RF. It should use the post-recieved, actual accepted amount of power by the MJ receiveracceptedMj. This caused a discrepancy in the amount of excessMJ (calculated based on post-receive), and the amount it was subtracted from (based on pre-receive) to calculateexactAcceptedMj.This caused crashes like this. This crash can be recreated with minimal mods in the below scenario:
An Extra Utilities (XU2) Energy Transfer node (extracting from an XU2 Creative Energy Source) with cable connected to an obsidian pipe, and throwing any item into the obsidian pipe. I've verified in a minimal instance (Buildcraft + Extra Utiltiies) that this setup no longer crashes with the changes.
Should fix BuildCraft/BuildCraft#4730, it's a similar crash.