X Tutup
Skip to content

Commit 4e77c93

Browse files
committed
Update Migration Guide document. Changes to Mac apps that
integrate into existing message loops (Qt, wxPython) (cztomczak#442).
1 parent b20c79b commit 4e77c93

File tree

3 files changed

+25
-8
lines changed

3 files changed

+25
-8
lines changed

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,8 @@ Additional information for v31.2 release:
254254
- [Tutorial](docs/Tutorial.md)
255255

256256

257-
### API categories
258-
257+
### API categories
258+
259259
#### Modules
260260

261261
* [cefpython](api/cefpython.md#cefpython) module
@@ -310,9 +310,9 @@ Additional information for v31.2 release:
310310
* [StringVisitor](api/StringVisitor.md#stringvisitor-interface) interface
311311
* [WebRequestClient](api/WebRequestClient.md#webrequestclient-interface) interface
312312

313-
314-
### API index
315-
313+
314+
### API index
315+
316316
* [Application settings](api/ApplicationSettings.md#application-settings)
317317
* [accept_language_list](api/ApplicationSettings.md#accept_language_list)
318318
* [app_user_model_id](api/ApplicationSettings.md#app_user_model_id)
@@ -652,7 +652,7 @@ Additional information for v31.2 release:
652652
* [ERR_UNSAFE_REDIRECT](api/NetworkError.md#err_unsafe_redirect)
653653
* [PaintBuffer (object)](api/PaintBuffer.md#paintbuffer-object)
654654
* [GetIntPointer](api/PaintBuffer.md#getintpointer)
655-
* [GetString](api/PaintBuffer.md#getstring)
655+
* [GetBytes](api/PaintBuffer.md#getbytes)
656656
* [RenderHandler (interface)](api/RenderHandler.md#renderhandler-interface)
657657
* [GetRootScreenRect](api/RenderHandler.md#getrootscreenrect)
658658
* [GetViewRect](api/RenderHandler.md#getviewrect)

api/API-index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@
341341
* [ERR_UNSAFE_REDIRECT](NetworkError.md#err_unsafe_redirect)
342342
* [PaintBuffer (object)](PaintBuffer.md#paintbuffer-object)
343343
* [GetIntPointer](PaintBuffer.md#getintpointer)
344-
* [GetString](PaintBuffer.md#getstring)
344+
* [GetBytes](PaintBuffer.md#getbytes)
345345
* [RenderHandler (interface)](RenderHandler.md#renderhandler-interface)
346346
* [GetRootScreenRect](RenderHandler.md#getrootscreenrect)
347347
* [GetViewRect](RenderHandler.md#getviewrect)

docs/Migration-guide.md

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ Table of contents:
4444
* [v66+ BrowserSettings.javascript_open_windows_disallowed option was removed](#v66-browsersettingsjavascript_open_windows_disallowed-option-was-removed)
4545
* [v66+ Threads removed: TID_DB, TID_PROCESS_LAUNCHER, TID_CACHE](#v66-threads-removed-tid_db-tid_process_launcher-tid_cache)
4646
* [v66+ cef.Request.Flags changed](#v66-cefrequestflags-changed)
47-
* [v66+ RequestHandler.GetCookieManager 'browser' param may be None](#v66-requesthandlergetcookiemanager-browser-param-may-be-none)
47+
* [v66+ RequestHandler.GetCookieManager not getting called in some cases](#v66-requesthandlergetcookiemanager-not-getting-called-in-some-cases)
48+
* [v66+ Changes to Mac apps that integrate into existing message loops (Qt, wxPython)](#v66-changes-to-mac-apps-that-integrate-into-existing-message-loops-qt-wxpython)
4849

4950

5051

@@ -384,3 +385,19 @@ In some cases the RequestHandler.[GetCookieManager](../api/RequestHandler.md#get
384385
callback is not getting called due to a race condition.
385386
This bug is to be fixed in Issue [#429](../../../issues/429).
386387

388+
389+
## v66+ Changes to Mac apps that integrate into existing message loops (Qt, wxPython)
390+
391+
The `qt.py` and `wxpython.py` examples were modified to set
392+
ApplicationSettings.[external_message_pump](../api/ApplicationSettings.md#external_message_pump)
393+
to `True`. Due to Issue [#442](../../../issues/442) it is required
394+
to implement both approaches to integrating with existing message
395+
loops at the same time:
396+
1. Call `cef.DoMessageLoopWork` in a 10ms timer
397+
2. Set `ApplicationSettings.external_message_pump` to True
398+
399+
This is not a correct approach and is only a temporary fix. More
400+
testing is required to check if that resolves all the issues with message
401+
loop freezing. Only basic testing was performed. It was not tested of
402+
how this change affects performance.
403+

0 commit comments

Comments
 (0)
X Tutup