squid:S1488 - Local Variables should not be declared and then immediately returned or thrown

Mohammed Ezzat · Mohammed Ezzat · commit 4e40cc38886c · 2016-01-27T02:45:39.000+02:00
diff --git a/caching/src/main/java/com/iluwatar/caching/DbManager.java b/caching/src/main/java/com/iluwatar/caching/DbManager.java
@@ -72,9 +72,7 @@ public static UserAccount readFromDb(String userId) {
       return null;
     }
     Document doc = iterable.first();
-    UserAccount userAccount =
-        new UserAccount(userId, doc.getString("userName"), doc.getString("additionalInfo"));
-    return userAccount;
+    return new UserAccount(userId, doc.getString("userName"), doc.getString("additionalInfo"));
   }
 
   /**
diff --git a/dao/src/main/java/com/iluwatar/dao/Customer.java b/dao/src/main/java/com/iluwatar/dao/Customer.java
@@ -66,7 +66,6 @@ public boolean equals(final Object o) {
 
   @Override
   public int hashCode() {
-    int result = getId();
-    return result;
+    return getId();
   }
 }
diff --git a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java
@@ -204,8 +204,7 @@ public NEW_TYPE computeNext() {
    */
   @Override
   public List<TYPE> asList() {
-    List<TYPE> copy = FluentIterable.copyToList(iterable);
-    return copy;
+    return FluentIterable.copyToList(iterable);
   }
 
   @Override
diff --git a/naked-objects/webapp/src/main/java/domainapp/webapp/SimpleApplication.java b/naked-objects/webapp/src/main/java/domainapp/webapp/SimpleApplication.java
@@ -118,8 +118,7 @@ public WebRequest newWebRequest(HttpServletRequest servletRequest, String filter
     } catch (Exception e) {
       System.out.println(e);
     }
-    WebRequest request = super.newWebRequest(servletRequest, filterPath);
-    return request;
+    return super.newWebRequest(servletRequest, filterPath);
   }
 
   @Override
@@ -150,8 +149,7 @@ private static String readLines(final Class<?> contextClass, final String resour
       List<String> readLines =
           Resources.readLines(Resources.getResource(contextClass, resourceName),
               Charset.defaultCharset());
-      final String aboutText = Joiner.on("\n").join(readLines);
-      return aboutText;
+      return Joiner.on("\n").join(readLines);
     } catch (IOException e) {
       return "This is a simple app";
     }

Original file line number	Diff line number	Diff line change
`@@ -72,9 +72,7 @@ public static UserAccount readFromDb(String userId) {`
`72`	`72`	`return null;`
`73`	`73`	`}`
`74`	`74`	`Document doc = iterable.first();`
`75`		`- UserAccount userAccount =`
`76`		`- new UserAccount(userId, doc.getString("userName"), doc.getString("additionalInfo"));`
`77`		`- return userAccount;`
	`75`	`+ return new UserAccount(userId, doc.getString("userName"), doc.getString("additionalInfo"));`
`78`	`76`	`}`
`79`	`77`
`80`	`78`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ public boolean equals(final Object o) {`
`66`	`66`
`67`	`67`	`@Override`
`68`	`68`	`public int hashCode() {`
`69`		`- int result = getId();`
`70`		`- return result;`
	`69`	`+ return getId();`
`71`	`70`	`}`
`72`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -204,8 +204,7 @@ public NEW_TYPE computeNext() {`
`204`	`204`	`*/`
`205`	`205`	`@Override`
`206`	`206`	`public List<TYPE> asList() {`
`207`		`- List<TYPE> copy = FluentIterable.copyToList(iterable);`
`208`		`- return copy;`
	`207`	`+ return FluentIterable.copyToList(iterable);`
`209`	`208`	`}`
`210`	`209`
`211`	`210`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -118,8 +118,7 @@ public WebRequest newWebRequest(HttpServletRequest servletRequest, String filter`
`118`	`118`	`} catch (Exception e) {`
`119`	`119`	`System.out.println(e);`
`120`	`120`	`}`
`121`		`- WebRequest request = super.newWebRequest(servletRequest, filterPath);`
`122`		`- return request;`
	`121`	`+ return super.newWebRequest(servletRequest, filterPath);`
`123`	`122`	`}`
`124`	`123`
`125`	`124`	`@Override`
`@@ -150,8 +149,7 @@ private static String readLines(final Class<?> contextClass, final String resour`
`150`	`149`	`List<String> readLines =`
`151`	`150`	`Resources.readLines(Resources.getResource(contextClass, resourceName),`
`152`	`151`	`Charset.defaultCharset());`
`153`		`- final String aboutText = Joiner.on("\n").join(readLines);`
`154`		`- return aboutText;`
	`152`	`+ return Joiner.on("\n").join(readLines);`
`155`	`153`	`} catch (IOException e) {`
`156`	`154`	`return "This is a simple app";`
`157`	`155`	`}`