Fix bug in bucketSort so that a comparison function is now provided to the sort function

charliejmoore · charliejmoore · commit 877356fbab8c · 2021-10-04T18:33:35.000-04:00
The [built-in JavaScript sort method](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort) will perform a lexicographical (aka alphabetical) order by converting the elements of the array to strings. This can yield unexpected results when sorting numbers. A comparison function can be passed into the sort method to indicate how array elements should be compared.
diff --git a/Sorts/BucketSort.js b/Sorts/BucketSort.js
@@ -53,7 +53,7 @@ function bucketSort (list, size) {
   const sorted = []
   // now sort every bucket and merge it to the sorted list
   for (let iBucket = 0; iBucket < buckets.length; iBucket++) {
-    const arr = buckets[iBucket].sort()
+    const arr = buckets[iBucket].sort((a, b) => a - b)
     for (let iSorted = 0; iSorted < arr.length; iSorted++) {
       sorted.push(arr[iSorted])
     }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ function bucketSort (list, size) {`
`53`	`53`	`const sorted = []`
`54`	`54`	`// now sort every bucket and merge it to the sorted list`
`55`	`55`	`for (let iBucket = 0; iBucket < buckets.length; iBucket++) {`
`56`		`- const arr = buckets[iBucket].sort()`
	`56`	`+ const arr = buckets[iBucket].sort((a, b) => a - b)`
`57`	`57`	`for (let iSorted = 0; iSorted < arr.length; iSorted++) {`
`58`	`58`	`sorted.push(arr[iSorted])`
`59`	`59`	`}`