Closed
Conversation
This commit addresses a typo in the code that yields unexpected results. In the cell, `results, run_simulation(...)` causes the simulation to be run correctly, but the results are never assigned back to the original `results` variable, meaning that the fraction of infected individuals is never updated over the course of the sweep. When running this code, it then seems like the fraction of infected individuals never changes, regardless of the number of doses (and resulting changes in beta).
Owner
|
Fixed with 387a6ae Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a typo in the code that yields unexpected results.
In the cell,
results, run_simulation(...)causes the simulation to berun correctly, but the results are never assigned back to the original
resultsvariable, meaning that the fraction of infected individuals isnever updated over the course of the sweep. When running this code, it
then seems like the fraction of infected individuals never changes,
regardless of the number of doses (and resulting changes in beta).