The assertItemsEqual method has been removed in Python 3.3 [1] but
it was kept alive by unittest2, imported by testtools. For better
compatibility, change to assertCountEqual.
[1] https://bugs.python.org/issue17866
Change-Id: Iea76915f25eb2e505750d509bdd06758afe324de
(cherry picked from commit b5603cc45c)
The unit test 'tackerclient.tests.unit.osc.v1.test_vnflcm_op_occs.
TestListVnfLcmOp.test_take_action_with_filter' is failing with below
error message,
DEBUG: TypeError: Object of type 'FormatComplexDataColumn' is not
JSON serializable
Background:
In class TestListVnfLcmOp definition, "create_vnflcm_op_occs" function
is called and list of fake vnflcm op occs dictionary is store in
vnflcm_op_occs_obj.
Now this dictionary is used in two unit test cases "test_take_action"
and "test_take_action_with_filter".
In order to evaluate test results, in "test_take_action" test case,
"get_vnflcm_op_occ_data" function is called using "vnflcm_op_occs_obj"
which appends the data in dictionary.
Later this dictionary "vnflcm_op_occs_obj" is again used in
"test_take_action_with_filter".
Implementation:
This patch creates a separate list of fake vnflcm op occs dictionary for
both the test cases.
This issue has been impacting below reviews as well,
[1] https://review.opendev.org/c/openstack/python-tackerclient/+/636893
[2] https://review.opendev.org/c/openstack/python-tackerclient/+/781314
Co-Authored: Yasufumi Ogawa <yasufum.o@gmail.com>
Closes-Bug: #1919350
Change-Id: I0d62f77cf5d1e9ec0b0a7c404abab83f97b708ba
Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.
Until the requirements repository has as stable/wallaby branch, tests will
continue to use the upper-constraints list on master.
Change-Id: I8f54797a47e23e4cf549792e1888db3774274405
As we agreed, drop lower constraints test from stable branches to avoid
difficulty of maintaining package depencencies for the recent pip
dependency resolver.
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
Change-Id: I24f675a0836eacef264254bb5da05286a1edf161
Add ``openstack vnflcm op list`` to python-tackerclient.
This command can execute getting the list of VNF LCM
Operation Occurrences. User can specify filters for more
specific results.
Note:
- Filtering for the following attributes:
operationParams, error, resourceChanges and
changedInfo is only limited to the parent
attribute. Currently, child attributes/nested
attributes are not searchable.
Implements: blueprint support-fundamental-lcm
Spec: https://specs.openstack.org/openstack/tacker-specs/specs/wallaby/support-fundamental-vnf-lcm-based-on-ETSI-NFV.html
Change-Id: Ie0b3399946d2a705011269025102d9380102ca92
In Victoria release, the error handling of non-existing VNF package
was modified, please refer to [1].
On passing a non-existing vnf package uuid to "vnf package upload"
command, the tacker server sends an HTTP response with "Content-Type"
header as "application/problem+json" and the reason for a failure
described in the JSON problem details object.
This patch extracts the ETSI error message in method
exception_handler_v10.
Fixes the issue and now it will output below error message:
$ openstack vnf package upload --path sample_vnf_pkg.zip dummy-id
Can not find requested vnf package: dummy-id
Note: This bug was earlier address in Ussuri release, please refer [2].
[1] https://review.opendev.org/c/openstack/tacker/+/747678/37/tacker/api/vnfpkgm/v1/controller.py
[2] https://review.opendev.org/c/openstack/python-tackerclient/+/688886
Co-Authored-By: Wataru Juso w-juso@nec.com
Closes-Bug: #1847726
Change-Id: I25e1bdc32e0b91bbe02b82f79918c02b98e5f110
In python 3, all strings are considered as unicode string.
This patch drops the explicit unicode literal (u'...')
or (u"..") appearances from the unicode strings.
Note: The scope of the patch is to drop unicode literal prefix
from python source code files, documentation and comment are overlook.
Co-Authored-By: Manpreet Kaur kaurmanpreet2620@gmail.com
Change-Id: I5316037871109838a03ff4561b7b38dcc56bc447
Scale command cannot be executed without '--additional-param-file'
option, because there is a problem with branch process. Modify branch
process when using this parameter.
And, I uniform cardinality mismatches of specification definition [1]
in some arguments are resolved. This change has no impact of the order
of setting.
[1]https://specs.openstack.org/openstack/tacker-specs/specs/victoria/support-scale-api-based-on-etsi-nfv-sol.html
Closes-Bug: #1903280
Change-Id: I1dd2c71760112982abd2b4b7da6dbaafd7077614
New rule enforcement has been enabled in the latest hacking code.
This patch bumps new version of hacking in test-requirements file,
for early detection and to avoid code breakage later when hacking
changes are released.
Change-Id: Ic54af7096b58259d6ee434a743ce9b75b7b61f28
This update is to drop all of six support to move
Closes-bug: #1900389
Change-Id: Ia6c61751203e98d432344dc9a52fe65bdb062af0
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
The description of the "openstack vnf package artifact download --help"
command is incorrect.Modify VNF Package or VNFD data to VNF Package
artifact file data.
Change-Id: Ib70efb7eefdb6eacea24dec67bb4ff996b6178d3
Closes-Bug: #1901103
Python modules related to coding style checks (listed in blacklist.txt in
openstack/requirements repo) are dropped from lower-constraints.txt
they are not needed during installation.
Change-Id: Ibc511139dca54a68b85b6d6731f491534fc1a909
Add file to the reno documentation build to show release notes for
stable/victoria.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.
Change-Id: I8136cb5c1422833a95b38e4e0545863ceb9a287e
Sem-Ver: feature
Currently in tacker, deleting the NS that already exist
has a problem like below Closes-Bug #1892151.
It has positional arguments error with command:
openstack ns delete <NS> (--force)
tacker ns-delete <NS> --force
because of client interface problem, so correct the
client's pyhton function delete_ns()
Change-Id: I7e100b065dbfb4503a5a45b10d3a962a4af36d76
Closes-Bug: #1892151
Currently in tacker, updating the VNFFG that already exist
has a problem like below Closes-Bug #1894945. To fix it,
add argument of '--param-file' and it works properly
Change-Id: I3f71c187fade9cd8b69a7131f274872975adf17c
Closes-Bug: #1894945
The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we don't need it
in lower-constraints.
These changes will help us to drop `mock` from openstack/requirements
Change-Id: I8d8db92664383e014dda76a4e7780628b72602fb
Fix some exception messages because some exception messages are not
outputed as expected.
In addition, the codes that seems to improve readability by explicitly
specifying the arguments are also modified.
Change-Id: I425d15ea9f5a3d0b6132ffd03cb577e583239c3a
Closes-Bug: #1881510
Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.
Change-Id: I1bae5d2d97304b81588ce059916326e1117136e3
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Co-Authored-By: Hiroo Kitamura <hiroo.kitamura@ntt-at.co.jp>
Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems
Update Sphinx version as well.
openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.
Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.
See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
Change-Id: Iafe611a36e17869bf17f5b2c016ef7c22fb36eb3
flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.
Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.
To avoid similar gate break in future, we need to bump the hacking min
version.
- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html
Change-Id: I6c1b4cad7cd112688b1955e2ef5243300fd1851e
To fix the issue because of using deprecated method in python3, replace
iteritems() with items().
Change-Id: If3136a5ba471d2cd7ea9420b599567a2fa532cad
Partial-Bug: 1872120
If user list vnf packages with --exclude_default option, it should
display all attributes except default set of complex.
$ openstack vnf package list --exclude_default
Expected fields:
'id', 'vnfProductName', 'onboardingState', 'usageState',
'operationalState', '_links', 'vnfdVersion', 'vnfProvider',
'vnfSoftwareVersion', 'vnfdId'
Actual fields displayed are:
'id', 'vnfProductName', 'onboardingState', 'usageState',
'operationalState'
Fixed this issue and now it will display fields as mentioned above in
expected fields.
Closes-Bug: 1875330
Change-Id: I61da40d2e6e7e42999b7ab2d2441cddde64118d9
