osc-lib 4.x introduced a change that removed support for legacy
callable functions used as formatters in CLI output.
The python-tackerclient code still uses such deprecated formatters,
which leads to the Invalid Formatter Provided error when used with
osc-lib>=4.0.0.
Replace these legacy callable formatters with compatible formatter
classes provided by osc_lib.cli.format_columns.
Closes-Bug: https://bugs.launchpad.net/tacker/+bug/2118585
Change-Id: Idc2a3be9fe709942904f472b7728e095ded92b19
Signed-off-by: Shivam Shukla <shivam.shukla3@india.nec.com>
This patch fixes the output of v2 Tacker so that vnfPkgId of
VnfInstance that are only used in v1 Tacker are not displayed
as CLI output.
This is because it is confusing for v2 users that unused vnfPkgId
(VNF Package ID) is always displayed as empty.
The vnfPkgId (VNF Package ID) remain displayed in the v1 Tacker
CLI output.
Change-Id: I4adea34e9c2c7fc51e087d2a00f47db77d67fe4a
This patch bumps the hacking version to 7.0.0 and fix the pep8
error:
- AttributeError: 'EntryPoints' object has no attribute 'get'
Closes-Bug: #2088356
Change-Id: Idb35decd157d19618b062d05951743083c04c32b
Tacker API add VNF Package ID to the Tacker V1 VNFLCM API.
This patch adds `VNF Package ID` to the output of
`openstack vnflcm show` command.
Fixes-bug: #2078757
Change-Id: I6edd3b5c080aff350cc6e1c8cab4f25bafe02890
- Fix so that Content-Type of the v1 modify vnflcm request is
"application/merge-patch+json".
- Fix so that as the same, Content-Type of all patch request is
"application/merge-patch+json".
- Fix so that Accept of all patch request and put vnfpkgm request
is "application/json".
- All patch request of above:
- PATCH VNF LCM(V1)
- PATCH VNF packages
- PATCH VNF LCM(V2)
- PATCH VNF FM
- PATCH VNF PM(Modify a PM job)
- PATCH VNF PM(Modify a PM threshold)
Closes-Bug: #2069701
Change-Id: Ia37312f1ba5560438970beffad432832d30d7d53
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
Co-Authored-By: Takahiro Miyajima <fj6257jz@fujitsu.com>
This method is has been unused used since [1] was merged. Removing it
allows us to remove oslo.log from the dependencies.
[1] 845a5e1439
Change-Id: I182b880e30ba09845218b4607447031fbdf067d0
According to SOL003, "authentication" should not appear
in the PmJobModifications response.
Therefore, it has been removed from the output obtained
when running "openstack vnfpm job update".
Closes-Bug: #2054420
Change-Id: I14b415a161983e682a4415d11d1fdad5792be3f8
If content-type other than application/json is used, an error occur
because the processing is lacked in HTTPClient to pass content-type.
So, this patch fixes the handling of `content-type` in HTTPClient.
Closes-Bug: #2052768
Change-Id: Ief823dbdec9cceea3c7129860381b9ab34d0e438
This patch obsoletes CLI for Legacy APIs excluding VIM feature.
Implements: blueprint deprecate-legacy-apis
Change-Id: I9be376a660c6f7c34c0abe7e327dec7a91d49ee2
This patch fixes the following issue of unit test that caused by
upgraded version of cliff library to v4.4.0.
-----
AttributeError: 'FakeStdout' object has no attribute 'isatty'
-----
Change-Id: I77438314f8cf98e62155b1e43da3484cd5f1f514
This patch resolves the following error caused by using one data in
multiple tests.
-----
ft1.2: tackerclient.tests.unit.osc.v1.test_vnflcm_subsc.
TestListLccnSubscription.test_take_action_with_
paginationtesttools.testresult.real._StringException:
Traceback (most recent call last):
File "/home/zuul/src/opendev.org/openstack/
python-tackerclient/tackerclient/tests/unit/osc/v1
/test_vnflcm_subsc.py", line 139, in test_take_action_with_
pagination
expected_data.append(vnflcm_subsc_fakes.get_subscription_
data(
File "/home/zuul/src/opendev.org/openstack
/python-tackerclient/tackerclient/tests/unit/osc/v1
/vnflcm_subsc_fakes.py", line 166, in get_subscription_data
subscription.pop(item)
KeyError: 'filter'
-----
Add test data for each test.
(Three data are set for each test data so that the first, last, and
other values can be checked.)
And change not to modify test data directly in get method.
Closes-Bug: #2007524
Change-Id: Id3919fc638f6b858c115a3a7d7e4ca60036217d4
This patch changes to allow setting the `extra` parameter in the VIM
configuration for openstack vim type.
Implements: blueprint enhance-api-policy
Change-Id: I37a3e21afced0aae6e0fd3c0cbb28ab16f2b7df8
Add the Performance Management Threshold CLI to support AutoScale.
The Performance Management Threshold API is based on ETSI NFV-SOL
002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is Version "2.0.0"
API of Tacker.
Implements: blueprint support-auto-lcm
Change-Id: Idd313d6abe47dfa41fc86ddc614d00f99f3fc3b2
This patch deprecates CLI for Legacy APIs excluding VIM feature.
Implements: blueprint deprecate-legacy-apis
Change-Id: Ib74db43b4a3de4676e61f4f9ce6d3d2095a11ddf
Support container based VNF AutoHeal and AutoScale operation with
External Monitoring Tools.
Add the Fault Management interfaces and CLI to support AutoHeal.
Add the Performance Management interfaces and CLI to support
AutoScale. The Fault Management and Performance Management
interfaces are based on ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL
003 v3.3.1, which are Version "2.0.0" API of Tacker. Add the
Prometheus Plugin that has a interface between tacker and the
External Monitoring Tool.
Implements: blueprint support-auto-lcm
Change-Id: I7023a72b73f17f3746c74d311919497c7c4e8b3f
This patch enables you to receive all records for target list
commands at once even if Tacker's server paginates them.
Target commands are below.
- openstack vnflcm list
- openstack vnflcm op list
- openstack vnflcm subsc list
* As for the following command, it will be supported after
implementing pagination feature in Tacker's server.
- openstack vnf package list
Implements: blueprint paging-query-result
Change-Id: I8e5c9bdd99b9c1e45aef8aa1e74bdbbfdd7c5c89
If the `extra` parameter is present in the config-file specified
when the 'openstack vim register' command is executed,
the data is sent to the tacker.
Implements: blueprint remove-cnf-restriction
Change-Id: I13420945f7d4f81f48a5be7f8f92a0635fbef18a
This patch adds openid auth info settings support when calling
vim register/update.
Implements: blueprint support-openid-k8s-vim
Change-Id: Id267050ac7adb349f562477dfc7aa6a53188b4cc
This patch supports CLI of vnflcm subscriptions APIs.
They are as follows.
* vnflcm subsc create
* vnflcm subsc delete
* vnflcm subsc list
* vnflcm subsc show
The output message of "vnflcm delete" was also modified
to match "vnflcm subsc delete".
Implements: blueprint support-nfv-solv3-subscriptions
Implements: blueprint support-etsi-nfv-specs
Change-Id: I9a839a3d131afc80fec0c2bbaa30443798117e0d
This patch supports CLI of vnflcm v2 APIs which are added in Yoga
release.
They are as follows.
* vnflcm update
* vnflcm scale
* vnflcm heal
* vnflcm change-ext-conn
* vnflcm op fail
* vnflcm op retry
* vnflcm op rollback
They are common with v1 except heal. An optional parameter
'--additional-param-file' is added to heal CLI.
Implements: blueprint support-nfv-solv3-heal-vnf
Implements: blueprint support-nfv-solv3-change-external-connectivity
Implements: blueprint support-nfv-solv3-modify-vnf
Implements: blueprint support-nfv-solv3-scale-vnf
Implements: blueprint support-nfv-solv3-error-handling
Change-Id: If4acd9c4d35ce7a5bf6c23db1a8238654d536c87
Usage message of all cli commands of tacker is constructed by
argument parser by default. It includes optional parameter
first and insert mandatory parameter at end.
All cli commands are implemented with this design only
except heal cli.
Heal cli is a special case in which optional parameter is
coming at end and mandatory parameter is coming before optional.
To fix this issue usage parameter of argument parser is set
in heal cli.
Closes-Bug: #1954744
Change-Id: I3b1d04df210ad07d4b9a99f300017d49e2b56f0b
"vnflcm op list" with "--exclude-fields" is not
excluding parameters from CLI result.
Closes-Bug: 1953377
Change-Id: If47beccfbab4b85173bbe159905d0605e721cedd
Add version '2' for support version of --os-tacker-api-version to
'openstack vnflcm' CLI.
If '--os-tacker-api-version 2' is specified, REST API url
'/vnflcm/v2' is used instead of '/vnflcm/v1'.
New CLI 'openstack vnflcm versions' is added too.
Implements: blueprint multi-version-api
Change-Id: I256a4010043d0b84ffe43b055c6a6a67a2d5d661
The testtools package removed safe_hasattr in version 2.5.0 [1].
Since it is only used in two unit tests, let's replace it with the
built-in hasattr.
[1] - https://github.com/testing-cabal/testtools/blob/2.5.0/NEWS#L31-L34
Change-Id: I57be2d06efe8913805069150bd3f884322a78a42
The use of `yaml.load` without Loader is deprecated and
considered unsafe.
The warning notice:
/opt/stack/python-tackerclient/tackerclient/tacker/v1_0/nfvo/vim.py:
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated,
as the default Loader is unsafe.
Please read https://msg.pyyaml.org/load for full details.
config_param = yaml.load(config_yaml)
This change adds (Loader=yaml.SafeLoader) to remove the warning.
Change-Id: Idc77d855b41801777d57cfe92d1c448b6e72feaa
This patch will resolve this issue and display the parameter
vnfConfigurableProperties in Query VNF. This parameter will be visible
in output of CLI like "openstack vnflcm show".
Closes-Bug: #1930571
Change-Id: I67b9bf854000ae52d2e1df40e4edf437713162b5
The assertItemsEqual method has been removed in Python 3.3 [1] but
it was kept alive by unittest2, imported by testtools. For better
compatibility, change to assertCountEqual.
[1] https://bugs.python.org/issue17866
Change-Id: Iea76915f25eb2e505750d509bdd06758afe324de
The unit test 'tackerclient.tests.unit.osc.v1.test_vnflcm_op_occs.
TestListVnfLcmOp.test_take_action_with_filter' is failing with below
error message,
DEBUG: TypeError: Object of type 'FormatComplexDataColumn' is not
JSON serializable
Background:
In class TestListVnfLcmOp definition, "create_vnflcm_op_occs" function
is called and list of fake vnflcm op occs dictionary is store in
vnflcm_op_occs_obj.
Now this dictionary is used in two unit test cases "test_take_action"
and "test_take_action_with_filter".
In order to evaluate test results, in "test_take_action" test case,
"get_vnflcm_op_occ_data" function is called using "vnflcm_op_occs_obj"
which appends the data in dictionary.
Later this dictionary "vnflcm_op_occs_obj" is again used in
"test_take_action_with_filter".
Implementation:
This patch creates a separate list of fake vnflcm op occs dictionary for
both the test cases.
This issue has been impacting below reviews as well,
[1] https://review.opendev.org/c/openstack/python-tackerclient/+/636893
[2] https://review.opendev.org/c/openstack/python-tackerclient/+/781314
Closes-Bug: #1919350
Change-Id: I0d62f77cf5d1e9ec0b0a7c404abab83f97b708ba
Add ``openstack vnflcm op list`` to python-tackerclient.
This command can execute getting the list of VNF LCM
Operation Occurrences. User can specify filters for more
specific results.
Note:
- Filtering for the following attributes:
operationParams, error, resourceChanges and
changedInfo is only limited to the parent
attribute. Currently, child attributes/nested
attributes are not searchable.
Implements: blueprint support-fundamental-lcm
Spec: https://specs.openstack.org/openstack/tacker-specs/specs/wallaby/support-fundamental-vnf-lcm-based-on-ETSI-NFV.html
Change-Id: Ie0b3399946d2a705011269025102d9380102ca92
