Merge "Fix create_threshold method when using cost as 0"

Fix create_threshold method when using cost as 0
When using 0 as the cost, the `create_threshold` method throws an exception. That happens because 0 (zero) is evaluated to False. Therefore, we need to change the validation method to check if the values are None. Change-Id: Iedd541c0ad16db0d11d6e6de332eddf880af1698
2020-12-22 16:20:55 +00:00 · 2020-12-11 10:25:10 -03:00 · 2020-11-27 12:41:36 +00:00 · 2020-09-25 11:55:49 +00:00 · 2020-09-25 11:55:48 +00:00 · 2020-09-22 00:50:20 +00:00
10 changed files with 40 additions and 27 deletions
--- a/.gitreview
+++ b/.gitreview
@@ -2,4 +2,3 @@
 host=review.opendev.org
 port=29418
 project=openstack/python-cloudkittyclient.git
-defaultbranch=stable/victoria
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -46,7 +46,7 @@
      - openstack-lower-constraints-jobs
      - check-requirements
      - openstack-cover-jobs
-      - openstack-python3-victoria-jobs
+      - openstack-python3-wallaby-jobs
      - openstackclient-plugin-jobs
      - publish-openstack-docs-pti
    check:
--- a/cloudkittyclient/v1/rating/hashmap.py
+++ b/cloudkittyclient/v1/rating/hashmap.py
@@ -373,7 +373,7 @@ class HashmapManager(base.BaseManager):
        :type level: str
        """
        for arg in ['cost', 'level']:
-            if not kwargs.get(arg):
+            if kwargs.get(arg) is None:
                raise exc.ArgumentRequired(
                    "'{}' argument is required".format(arg))
        if not kwargs.get('service_id') and not kwargs.get('field_id'):
--- a/lower-constraints.txt
+++ b/lower-constraints.txt
@@ -1,21 +1,20 @@
 # requirements
-pbr==2.0.0 # Apache-2.0
-cliff==2.11.0 # Apache-2.0
-keystoneauth1==3.4.0 # Apache-2.0
-oslo.utils==3.35 # Apache-2.0
-oslo.log==3.36 # Apache-2.0
-PyYAML==3.12 # MIT
-jsonpath-rw-ext==1.0 # Apache-2.0
-os-client-config==1.29.0 # Apache-2.0
-osc-lib==1.12.1 # Apache-2.0
+pbr==5.5.1 # Apache-2.0
+cliff==3.5.0 # Apache-2.0
+keystoneauth1==4.3.0 # Apache-2.0
+oslo.utils==4.7.0 # Apache-2.0
+oslo.log==4.4.0 # Apache-2.0
+PyYAML==5.3.1 # MIT
+jsonpath-rw-ext==1.2.0 # Apache-2.0
+os-client-config==2.1.0 # Apache-2.0
+osc-lib==2.3.0 # Apache-2.0

 # test-requirements.txt
 pyflakes==2.1.1
 coverage==4.0 # Apache-2.0
-python-subunit==0.0.18 # Apache-2.0/BSD
+python-subunit==1.4.0 # Apache-2.0/BSD
 oslotest==1.10.0 # Apache-2.0
 stestr==2.0 # Apache-2.0
-mock==2.0 # BSD
 python-openstackclient==3.14 # Apache-2.0

 # doc/requirements.txt
--- a/releasenotes/notes/fix-create_threshold-method-validation-f193e883e82214c9.yaml
+++ b/releasenotes/notes/fix-create_threshold-method-validation-f193e883e82214c9.yaml
@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    Fix `create_threshold` method when using cost as 0.
+    When using 0 as the cost, the `create_threshold` method
+    throws an exception. That happens because 0 (zero) is evaluated
+    to False. Therefore, we need to change the validation method to
+    check if the values are None.
--- a/releasenotes/source/index.rst
+++ b/releasenotes/source/index.rst
@@ -8,6 +8,7 @@ Contents
   :maxdepth: 2

   unreleased
+   victoria
   ussuri
   train
   stein
--- a/releasenotes/source/victoria.rst
+++ b/releasenotes/source/victoria.rst
@@ -0,0 +1,6 @@
+=============================
+Victoria Series Release Notes
+=============================
+
+.. release-notes::
+   :branch: stable/victoria
--- a/requirements.txt
+++ b/requirements.txt
@@ -2,12 +2,12 @@
 # of appearance. Changing the order has an impact on the overall integration
 # process, which may cause wedges in the gate later.

-pbr>=2.0.0,!=2.1.0 # Apache-2.0
-cliff>=2.11.0 # Apache-2.0
-keystoneauth1>=3.4.0 # Apache-2.0
-oslo.utils>=3.35 # Apache-2.0
-oslo.log>=3.36 # Apache-2.0
-PyYAML>=3.12 # MIT
-jsonpath-rw-ext>=1.0 # Apache-2.0
-os-client-config>=1.29.0 # Apache-2.0
-osc-lib>=1.12.1 # Apache-2.0
+pbr>=5.5.1 # Apache-2.0
+cliff>=3.5.0 # Apache-2.0
+keystoneauth1>=4.3.0 # Apache-2.0
+oslo.utils>=4.7.0 # Apache-2.0
+oslo.log>=4.4.0 # Apache-2.0
+PyYAML>=5.3.1 # MIT
+jsonpath-rw-ext>=1.2.0 # Apache-2.0
+os-client-config>=2.1.0 # Apache-2.0
+osc-lib>=2.3.0 # Apache-2.0
--- a/test-requirements.txt
+++ b/test-requirements.txt
@@ -2,7 +2,7 @@
 # of appearance. Changing the order has an impact on the overall integration
 # process, which may cause wedges in the gate later.

-hacking>=3.0,<3.1.0 # Apache-2.0
+hacking>=3.0.1,<3.1.0 # Apache-2.0

 # remove this pyflakes from here once you bump the
 # hacking to 3.2.0 or above. hacking 3.2.0 takes
@@ -10,7 +10,7 @@ hacking>=3.0,<3.1.0 # Apache-2.0
 pyflakes>=2.1.1

 coverage>=4.0,!=4.4 # Apache-2.0
-python-subunit>=0.0.18 # Apache-2.0/BSD
+python-subunit>=1.4.0 # Apache-2.0/BSD
 oslotest>=1.10.0 # Apache-2.0
 stestr>=2.0 # Apache-2.0
 python-openstackclient>=3.14 # Apache-2.0
--- a/tox.ini
+++ b/tox.ini
@@ -1,6 +1,6 @@
 [tox]
 minversion = 3.1.1
-envlist = py36,py37,pep8
+envlist = py36,py38,pep8
 skipsdist = True
 ignore_basepython_conflict = True

@@ -70,7 +70,7 @@ import_exceptions = cloudkittyclient.i18n

 [testenv:releasenotes]
 deps =
-  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/victoria}
+  -c{env:TOX_CONSTRAINTS_FILE:https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt}
  -r{toxinidir}/doc/requirements.txt
 commands =
  sphinx-build -a -E -W -d releasenotes/build/doctrees --keep-going -b html releasenotes/source releasenotes/build/html
Author	SHA1	Message	Date
Zuul	1e8b06243e	Merge "Fix `create_threshold` method when using cost as 0"	2020-12-22 16:20:55 +00:00
Rafael Weingärtner	a15f11a7d2	Fix `create_threshold` method when using cost as 0 When using 0 as the cost, the `create_threshold` method throws an exception. That happens because 0 (zero) is evaluated to False. Therefore, we need to change the validation method to check if the values are None. Change-Id: Iedd541c0ad16db0d11d6e6de332eddf880af1698	2020-12-11 10:25:10 -03:00
wuchunyang	c2b5ed9535	Replace deprecated UPPER_CONSTRAINTS_FILE variable UPPER_CONSTRAINTS_FILE is old name and deprecated -https://zuul-ci.org/docs/zuul-jobs/python-roles.html#rolevar-tox.tox_constraints_file This allows to use lower-constraints file as more readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>. Change-Id: I25d4154797da0453f59e310d2392d30ca35e5258	2020-11-27 12:41:36 +00:00
Zuul	bddf634143	Merge "Drop mock from lower-constraints.txt"	2020-09-25 11:55:49 +00:00
Zuul	5442134a5f	Merge "bump py37 to py38 in tox.ini"	2020-09-25 11:55:48 +00:00
wangzihao	3ec8f86e5a	bump py37 to py38 in tox.ini in 'victoria' cycle, we should test py38 by default. Change-Id: Ib01cf2aad3edf31a067a6ac4459529851f8d8ecb	2020-09-22 00:50:20 +00:00
wangzihao	5b35e817b2	Drop mock from lower-constraints.txt The mock is not needed for py36 and later. Change-Id: I24afe1f1255ac47dfba300946149732f70f5f399	2020-09-21 11:46:13 +08:00
wangzihao	953c6c9443	Bump hacking min version to 3.0.1 hacking 3.0.1 fix the pinning of flake8 to avoid bringing in a new version with new checks. bumping the min version for hacking so that any older hacking versions which auto adopt the new checks are not used. Change-Id: I5875f1c0261ff6039773d7daf412102f2c02651f	2020-09-18 10:36:40 +08:00
OpenStack Release Bot	30e21ddf7b	Add Python3 wallaby unit tests This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for wallaby. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: I4c238eefa02cece34ee8f77a0dee91a5bf698a65	2020-09-08 22:47:17 +00:00
OpenStack Release Bot	c24de5fe54	Update master for stable/victoria Add file to the reno documentation build to show release notes for stable/victoria. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/victoria. Change-Id: Ifdc6cb5adbb2139a2437d220b231c1c61526e648 Sem-Ver: feature	2020-09-08 22:47:15 +00:00